refactor!: proof_of_sql_parser::intermediate_ast::UnaryOp with sqlparser::ast::UnaryOp in the proof-of-sql crate
#363
+29
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varshith257
force-pushed
the
fix-unaryop1
branch
from
3a5c58f to
1cd95f2
Compare
|
@varshith257 Let's get #344 merged first so that your PR can be simpler. :) |
iajoiner
reviewed
Nov 11, 2024
iajoiner
reviewed
Nov 11, 2024
iajoiner
reviewed
Nov 11, 2024
varshith257
force-pushed
the
fix-unaryop1
branch
4 times, most recently
from
e5664f3 to
2cf0724
Compare
varshith257
changed the title
proof_of_sql_parser::intermediate_ast::UnaryOp with sqlparser::ast::UnaryOp in the proof-of-sql crate
varshith257
force-pushed
the
fix-unaryop1
branch
2 times, most recently
from
92192fc to
8075a5c
Compare
iajoiner
approved these changes
Nov 11, 2024
iajoiner
force-pushed
the
fix-unaryop1
branch
from
8075a5c to
7b3c87f
Compare
JayWhite2357
approved these changes
Nov 12, 2024
iajoiner
force-pushed
the
fix-unaryop1
branch
from
7b3c87f to
b9abb8f
Compare
|
🎉 This PR is included in version 0.43.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.Rationale for this change
This PR addresses the need to replace the
proof_of_sql_parser::intermediate_ast::UnaryOpwith thesqlparser::ast::UnaryOpin theproof-of-sqlcrate as part of a larger transition toward integrating thesqlparser.This change is a subtask of issue #235, with the main goal of streamlining the repository by switching to the
sqlparsercrate and gradually replacing intermediary constructs likeproof_of_sql_parser::intermediate_astwithsqlparser::ast.What changes are included in this PR?
proof_of_sql_parser::intermediate_ast::UnaryOphave been replaced withsqlparser::ast::UnaryOpUnaryOphas been updated to maintain the original functionality, ensuring no changes to the logic or behavior.UnaryOpvariants fromsqlparserhave been appropriately handled using existing error handling mechanisms (i.e., theUnsupportedvariant inExpressionEvaluationError).Are these changes tested?
Yes
Part of #235